fix(test): fix CachedLDAPAuthorizationModuleLegacyTest flakiness caused by Thread.sleep()#1748
Merged
jbonofre merged 1 commit intoapache:mainfrom Mar 10, 2026
Conversation
…ed by Thread.sleep Replace Thread.sleep calls with Wait.waitFor in AbstractCachedLDAPAuthorizationMapLegacyTest to fix testRestartAsync timeout. The root cause was that getReadACLs called while LDAP was down triggered an async reconnection task that blocked the single-threaded updater on a TCP connect timeout, causing all subsequent reconnection attempts to be silently discarded.
jeanouii
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Thread.sleep()calls withWait.waitFor()inAbstractCachedLDAPAuthorizationMapLegacyTestto fixtestRestartAsynctimeout.The root cause was that
getReadACLscalled while LDAP was down triggered an async reconnection task that blocked the single-threaded updater on a TCP connect timeout, causing all subsequent reconnection attempts to be silently discarded.